-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Desktop: rewrite reserved area handling + improve tests #12383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vaxerski
wants to merge
5
commits into
hyprwm:main
Choose a base branch
from
vaxerski:rewrite-reserved
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
this now works with the original usecase but breaks some tests |
aaad351 to
579615d
Compare
Member
Author
|
I hate my life |
295f2d9 to
db997fd
Compare
Member
Author
|
snap tests still fail but @fufexan I added gtest here can you add it to nix and arch deps and add it to test CI? |
vaxerski
added a commit
to hyprwm/hyprland-wiki
that referenced
this pull request
Nov 21, 2025
30d4a3e to
0ae8082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wip, unfinished. Can't do more today my brain fried
Rewrites reserved area handling, reserved should also have a clear outer gap container for retrieving the work area with outer gaps for layouts.
Supersedes #12047
Test wiki MR hyprwm/hyprland-wiki#1293
todo: